Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0 plans #5

Closed
2 tasks done
hwchen opened this issue Jan 29, 2017 · 8 comments
Closed
2 tasks done

1.0 plans #5

hwchen opened this issue Jan 29, 2017 · 8 comments
Assignees

Comments

@hwchen
Copy link
Owner

hwchen commented Jan 29, 2017

Next plans for this lib:

  • figure out cross-compilation details (making sure unneeded dependencies are not compiled?) (v0.3.0)
  • windows backend (v0.3.0)
  • design: should osx keychain be unlocked from cli (only required from ssh)?
  • traits-based design?
  • tests and CI.
  • docs
  • osx backend with https://crates.io/crates/security-framework (which I think should work)

Edit (9/27/2018):

I think this library has been used enough that I'm going to go ahead and plan for 1.0 without major changes to this library. I only need to clean up the secret-service library a bit, move that to 1.0, and then I'll be able to release 1.0 here.

See new issue: #21

@hwchen hwchen changed the title 0.2 plans 0.3 plans Feb 13, 2017
@hwchen hwchen self-assigned this Feb 17, 2017
@hwchen hwchen changed the title 0.3 plans 1.0 plans Feb 17, 2017
@steveatinfincia
Copy link
Contributor

I would be happy to help convert the OS X support to use security-framework :)

At the moment I think the only thing blocking that is support for storing/retrieving generic passwords in the keychain in security-framework, but there is a pull request open for that. I may take a look at that as well to see if there is anything I can do to help get that one merged.

@hwchen
Copy link
Owner Author

hwchen commented Feb 28, 2017

That would be awesome! Keep me posted.

@steveatinfincia
Copy link
Contributor

I'm about 95% done with the OS X keychain support, just doing some testing :)

@hwchen
Copy link
Owner Author

hwchen commented Mar 14, 2017 via email

@dario23
Copy link

dario23 commented Dec 16, 2017

will there be support for setting a different application name on linux in the forseeable future? :-)

@hwchen
Copy link
Owner Author

hwchen commented Dec 18, 2017

@dario23 Could be :) I'll be doing some updates to dependencies soon (including winapi 0.3 and a pull request for rpassword), so I'll try to also do work for support for different application names.

@dario23
Copy link

dario23 commented Dec 19, 2017

i could write a pull request as well; but the question (i guess) isn't about who writes the (presumably) short patch, but rather how you'd want it to fit into the existing API

  • the types for linux, windows and osx are currently different types with the same signature; how willing are you to have the implementations diverge?
  • alternatively it could be a possibility to have a "set the application name" part in the API for all variants, that doesn't do anything for osx/windows; or (if possible, not sure) a separate method that is later called and sets the application name to something else?

@hwchen
Copy link
Owner Author

hwchen commented Jan 11, 2018

@dario23 sorry for delay. I've finally had some time to look over my code and think about your suggestions.

Something that would help me decide on the API is how you're using application differently than service.

I prefer that implementations do not diverge; it's better that I have responsibility for keeping all the cross-platform stuff in order, otherwise the code that users write will not be easily cross-platform.

I do think that your second option is maybe possible, I just want to check on your use case and see if there's another solution possible.

@hwchen hwchen closed this as completed Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants