Track down and avoid the windows test failures #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `test_simultaneous_create_set_move` so that it does the set in the thread, so it's really `test_simultaneous_create_move_set`
Apparently the windows credential manager doesn't consistently work if you set and then read (or delete) the same entry from different threads. So conditionalize the tests to avoid this on Windows, and add a documentation about this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have altered the Windows tests so that they don't set a credential on one thread and then immediately access that credential from another thread. With that change, the Windows tests seem to work reliably.
I have updated the docs to warn clients that this pattern of access is known to fail on Windows, and added a feature that can be used to run those tests on Windows in case Microsoft fixes these issues in future.
This "fixes #163" in a manner of speaking.