Update dependencies #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, updating the dependency on secret-service means that keyring-rs no longer depends on the system dbus library on linux.
|
Hey, thanks for this. Sorry I’ve been a little slow on getting key ring updated, work has been pretty busy. I’ll try to get things rolling again. |
|
@hwchen Thank you so much for your work on keyring-rs and on the underlying platform-specific integrations for Windows, Linux and MacOS! |
|
Hi @Victor-Savu, thanks so much for leading the way here! We have now integrated the dependency updates in #66 so I closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, updating the dependency on secret-service-rs means that
keyring-rs no longer depends on the system dbus library on linux.
I know secret-service-rs is still in pre-release, but I thought I'd open the PR just so that it is ready when the time comes.