Change windows implementation to use windows-rs and change error to this error #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaysonsantos
force-pushed
the
windows-crate-and-thiserror
branch
3 times, most recently
from
f396f02
to
3af920c
Compare
jaysonsantos
force-pushed
the
windows-crate-and-thiserror
branch
from
3af920c
to
99fa4fb
Compare
jaysonsantos
force-pushed
the
windows-crate-and-thiserror
branch
from
99fa4fb
to
b636206
Compare
Closed
|
I don't think switching to windows-rs is a good idea since it doesn't support crosscompiling yet (as far as I can tell, see microsoft/windows-rs#638). Sticking with winapi until that changes seems like a safer bet to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a WIP, I am submitting so I can see the errors on the other OSes as hopping between computers is a bit annoying.