-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump zbus to 2.0.0-beta.7 #37
Conversation
Thanks for the PR to see what this would look like. Is there any ETA for when Zbus plans to do a make a stable release of 2.0? I was not able to find any tracking issue on the GitLab repository. |
Not sure if there’s an ETA but I think it’ll get released soon since there have been 5 beta releases already |
Hi, zbus maintainer here.
Given that nobody works on zbus as their day job, it's hard to give a good estimate about 2.0 delivery day. What I can tell you is that we're very close to the API freeze. There may be API breakages before 2.0 but apart from dropping the proxy signal/property callback API (which this PR doesn't seem to be using directly at least), there are unlikely to be any major changes after beta.7. |
Ah sorry, somehow I completely forgot to reply, @zeenix . Thanks for the estimate. I think at this point it"d be best to merge this into master and make a new release once zbus 2 is released. |
NP. Actually, I'm hoping to release a API-freeze release today or tomorrow as there are no other API breakages planned. Then comes 2.0 in some days/weeks after people get a chance to test the API a bit more. There might still be API breakages before 2.0 but the chances are extremely low and will only happen if absolutely necessary. |
Thanks, updated this PR to beta8 |
It looks like version 2.0.0 has been released! @zeenix thanks for the work that went into the release 🎉 @Cogitri Would you mind please updating this branch to use the stable version? I'll run CI again once you do. Please rebase onto |
d62e126
to
3baaf9c
Compare
Seems like tests currently fail though, I'll look into that in a bit. |
You're most welcome! It was indeed a lot of hard work to get the async API sorted. I hope you're happy with the results. :) |
3 Tests still fail for me - but maybe that's just due to my system? AFAICS
|
I took the test suite through a run in a fresh Ubuntu 20.04 instance and got similarly interesting results. With this branch, I got a total of 4 test failures:
On
So, in total, there's a net gain of 3 failures. I think that some of these, especially the unknown method error, should be looked at before this is merged as it appears to be a regression (even in the face of these tests being shaky). |
That one is especially weird - are you sure that the keyring is actual functional on that Ubuntu install? Seems like others only get the same DBus error when SSH'ing into the machine, see e.g. jaraco/keyring#514 (comment) |
Oh also - are you running with multiple test thread? That seems to result in similar errors at random for me. |
With the latest commit all tests pass for me. |
zbus 2.x has enabled the caching of properties upon first reading them. This messes with some of our functionality, like reading the correct name of an Item after changing it. We should probably look into cache invalidation down the line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the tests now pass for me, even in multithreaded mode, so I think this is good to go. Thanks again for doing this.
The CI failure is unrelated. Its happening because the |
Fixes #36