windows_live: client ID required in the request made to Microsoft

[BenoitDuffez]

Q	A
Bug?	yes
New Feature?	no
Support question?	yes
Version	2.2.0

Actual Behavior

What is the actual behavior?

Similar to comment #1425 (comment) but did not solve my issue.

When logging in with a properly (?? I may have made a mistake though!) configured windows_live, the request fails silently after logging in on Microsoft side.

The Symfony profiler shows the response sent by Microsoft:

[▼
  "info" => [▶]
  "response_headers" => [▶]
  "response_json" => [▼
    "error" => "invalid_client"
    "error_description" => "The provided request must include a 'client_id' input parameter."
    "correlation_id" => "xx-xx-xx-xx-xx"
  ]
]

Expected Behavior

What is the behavior you expect?

I think it should have worked

Steps to Reproduce

I don't have reproduction code as I followed the docs however I debugged the call stack of this error and how the HTTP request is built, and adding these two lines fixes the issue:

 // GenericOAuth2ResourceOwner.php
 public function getAccessToken(HttpRequest $request, $redirectUri, array $extraParameters = [])
 {
     OAuthErrorHandler::handleOAuthError($request);
     $parameters = array_merge([
         'code' => $request->query->get('code'),
         'grant_type' => 'authorization_code',
         'redirect_uri' => $redirectUri,
+        'client_id' => $this->options['client_id'],
+        'client_secret' => $this->options['client_secret'],
     ], $extraParameters);
     $response = $this->doGetTokenRequest($this->options['access_token_url'], $parameters);
     $response = $this->getResponseContent($response);
     $this->validateResponseContent($response);
     return $response;
 }

Possible Solutions

I don't know if my proposal above is bogus because I did not configure the bundle properly (most likely) or if there was a change somewhere in the API?

[BenoitDuffez]

Is there anything I can do to make this ticket move forward? – Thanks

[github-actions]

Message to comment on stale issues. If none provided, will not mark issues stale

[BenoitDuffez]

Any update? How can I help? (hi GitHub bot)

[github-actions]

Message to comment on stale issues. If none provided, will not mark issues stale

[BenoitDuffez]

Would you accept a MR?

[XWB]

Yes, feel free to open a pull request.

[BenoitDuffez]

Thanks, hope to see it in a tag soon.