Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement base app-gateway contract for frontend #96

Merged
merged 5 commits into from
Jan 21, 2019

Conversation

faraonc
Copy link
Member

@faraonc faraonc commented Jan 21, 2019

Feature

hwsc-org/hwsc-app-gateway-svc#9

Below are the initial expected services for the frontend.
These services are NOT the same with the other services.

For example:

rpc CreateUser (AppGatewayServiceRequest) returns (AppGatewayServiceResponse) {} will use
hwsc-user-svc's CreateUser and hwsc-file-transaction-svc's CreateUserFolder

    rpc GetStatus (AppGatewayServiceRequest) returns (AppGatewayServiceResponse) {}
    rpc CreateUser (AppGatewayServiceRequest) returns (AppGatewayServiceResponse) {}
    rpc DeleteUser (AppGatewayServiceRequest) returns (AppGatewayServiceResponse) {}
    rpc UpdateUser (AppGatewayServiceRequest) returns (AppGatewayServiceResponse) {}
    rpc AuthenticateUser (AppGatewayServiceRequest) returns (AppGatewayServiceResponse) {}
    rpc ListUsers (AppGatewayServiceRequest) returns (AppGatewayServiceResponse) {}
    rpc GetUser (AppGatewayServiceRequest) returns (AppGatewayServiceResponse) {}
    rpc ShareDocument (AppGatewayServiceRequest) returns (AppGatewayServiceResponse) {}
    rpc CreateDocument (AppGatewayServiceRequest) returns (AppGatewayServiceResponse) {}
    rpc ListUserDocumentCollection (AppGatewayServiceRequest) returns (AppGatewayServiceResponse) {}
    rpc UpdateDocument (AppGatewayServiceRequest) returns (AppGatewayServiceResponse) {}
    rpc DeleteDocument (AppGatewayServiceRequest) returns (AppGatewayServiceResponse) {}
    rpc AddFile (AppGatewayServiceRequest) returns (AppGatewayServiceResponse) {}
    rpc DeleteFile (AppGatewayServiceRequest) returns (AppGatewayServiceResponse) {}
    rpc ListDistinctFieldValues (AppGatewayServiceRequest) returns (AppGatewayServiceResponse) {}
    rpc QueryDocument (AppGatewayServiceRequest) returns (AppGatewayServiceResponse) {}

@faraonc faraonc added the enhancement New feature or request label Jan 21, 2019
@faraonc faraonc self-assigned this Jan 21, 2019
@faraonc faraonc changed the title Implement base app-gateway contract for frontend [WIP] Implement base app-gateway contract for frontend Jan 21, 2019
@faraonc faraonc force-pushed the feature/app-gateway-initial-proto branch from cf42dcd to 7e30b9b Compare January 21, 2019 10:05
@faraonc faraonc changed the title [WIP] Implement base app-gateway contract for frontend Implement base app-gateway contract for frontend Jan 21, 2019
@faraonc faraonc force-pushed the feature/app-gateway-initial-proto branch from 7e30b9b to a4c90fb Compare January 21, 2019 10:22
@kimlisa
Copy link
Contributor

kimlisa commented Jan 21, 2019

What about filter related calls? Such as getting a list of publishers getting a list of unique instruments, etc

Is ListDistinctFieldValues have something to do with that?

@faraonc
Copy link
Member Author

faraonc commented Jan 21, 2019

What about filter related calls? Such as getting a list of publishers getting a list of unique instruments, etc

Is ListDistinctFieldValues have something to do with that?

I just realized that I am doing all of that with one RPC call using ListDistinctFieldValues, but yes, ListDistinctFieldValues does that. It may need to be separated later on.

Copy link
Contributor

@kimlisa kimlisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TU

@faraonc faraonc merged commit 0f70e37 into master Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants