Added sabertooth driver #748
Conversation
There was a problem hiding this comment.
@elie-g thank you for sharing your code with the gobot project. I have finished my review just now. It would be perfect if you could take a few more minutes to add or change a few things.
| } | ||
|
|
||
| // SabertoothAnalogDriver represents a sabertooth driver in analog mode | ||
| type SabertoothAnalogDriver interface { |
There was a problem hiding this comment.
Please could you remove the interface and add the comments to the related exported functions.This is, because there is no further implementation of it and introducing of interfaces in golang is a little bit different according to other languages.
After that you could most likely also remove the "// END" comments in the code, because the beginning of the next function is marked by the description comment.
Reading this post will help to understand my remark.
| // Adds the following API commands: | ||
| // throttle(value float64) - see SabertoothAnalogDriver.Throttle | ||
| // differential(value float64) - see SabertoothAnalogDriver.Differential | ||
| func NewSabertoothAnalogDriver(w PwmWriter, d SabertoothDIPSwitches, s1, s2, a1, a2 string) SabertoothAnalogDriver { |
There was a problem hiding this comment.
Please could you add the link to the provided references in your commit message here in the code. This will simplify future development. You can have a look to i2c drivers for some examples.
A link to an reference code in another programming language is also helpful for future error catching, e.g. for i2c drivers there are often drivers already implemented in python or for arduino in C/C++.
|
|
||
| // NewSabertoothDIPSwitches creates a new SabertoothDIPSwitches given the | ||
| // position (true: ON, false: OFF) of the DIP switches 3, 4, 5 and 6. | ||
| func NewSabertoothDIPSwitches(powerSupply, mixed, linear, bidirectional bool) SabertoothDIPSwitches { |
There was a problem hiding this comment.
An example (/gobot/examples/*) would be nice to understand how to use the dip switches together with the driver.
| return s.write(s.a2, ratio) | ||
| } // END SetMaxPower | ||
|
|
||
| func (s *sabertoothAnalogDriver) Throttle(throttle float64) error { |
There was a problem hiding this comment.
This function looks quite complicate, so my suggestion is to add some unit test.
| } | ||
| } // END Throttle | ||
|
|
||
| func (s *sabertoothAnalogDriver) Differential(angle float64) error { |
There was a problem hiding this comment.
This function looks also quite complicate, so my suggestion is to add some unit test.
|
Set back to draft for later reference. |
gen2thomas
added
maintainer wanted
|
accidentally closed - now reopen |
I created a GPIO driver for the DimensionEngineer's Sabertooth motor driver.
I made it for my own usage and I thought you might want it.
See here for more information.