Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gobot update eventer #980

Draft
wants to merge 2 commits into
base: release
Choose a base branch
from

Conversation

wangzhenandy
Copy link

Solved issues and/or description of the change

你好,在项目开发中遇到了问题,希望做如下调整:

  1. 可以自定义eventer的channel长度
  2. 可以定义消费out channel的goroutine数量,实现多消费者模式
  3. 当回调函数执行panic时,可以通过crash事件输出

请审阅一下代码,修改是否合适。

...

Manual test

  • OS and Version (Win/Mac/Linux):
  • Adaptor(s) and/or driver(s):
    ...

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

If this is a new driver or adaptor:

  • I have added the name to the corresponding README.md
  • I have added an example to see how to setup and use it
  • I have checked or build at least my new example (e.g. by run make examples_check)

If this is a PR for release:

  • The PR's target branch is 'hybridgroup:release'
  • I have adjusted the CHANGELOG.md (or already prepared and will be merged as soon as possible)

@gen2thomas
Copy link
Collaborator

Hi @wangzhenandy , thanks for providing this PR. Please can you read our contributing guide. Additionally, please can you fix some characters in this issue, which I can not read, also in the code. At the moment I can not review because I can not understand the originated problem due to this characters.

Thanks Thomas

@gen2thomas
Copy link
Collaborator

Hi @wangzhenandy , I'm going to set this PR back to draft since there is no progress yet. Feel free to fix the remarks and set it back to active.

@gen2thomas gen2thomas marked this pull request as draft October 10, 2023 17:51
@gen2thomas gen2thomas self-assigned this Oct 10, 2023
@gen2thomas gen2thomas removed their assignment Nov 1, 2024
@gen2thomas gen2thomas added the maintainer wanted the implementation was started, but for some reason not finished label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer wanted the implementation was started, but for some reason not finished
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants