Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more functions used for stereo image processing. #1113

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

michaelarusso
Copy link
Collaborator

No description provided.

@michaelarusso
Copy link
Collaborator Author

I haven't had time to write full unit tests for these new bindings I've added, but they are pretty much pass through directly to opencv. I have tested the functionality when some internal end to end tests between an original cpp implementation and the same implementation in Go using GoCV and these work fine.

Let me know if there are any questions!

@deadprogram
Copy link
Member

@michaelarusso this looks great. Just needs some smoke tests to merge, as you know they do not need to be comprehensive, just touching the code changes is sufficient.

@michaelarusso
Copy link
Collaborator Author

michaelarusso commented Oct 17, 2023

@deadprogram I added the smoke tests plus an additional one for the MinMaxLoc func that pre-existed without a test. The AppVeyor build failed and seems unrelated to my change(some flaky test?). I'm not sure how to re-trigger the build without pushing another commit.

@deadprogram
Copy link
Member

I just restarted Appveyor build...

@deadprogram
Copy link
Member

Thank you very much @michaelarusso now merging.

@deadprogram deadprogram merged commit 3709676 into hybridgroup:dev Oct 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants