Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add float version of BoxPoints and MinAreaRect #1164

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Add float version of BoxPoints and MinAreaRect #1164

merged 1 commit into from
Mar 30, 2024

Conversation

TeCHiScy
Copy link
Contributor

This PR add float version of BoxPoints and MinAreaRect, named BoxPoints2f and MinAreaRect2f, respectively. Structs including RotatedRect2f and Size2f are also added to support this feature.

close #1152

@TeCHiScy
Copy link
Contributor Author

Hi @deadprogram, the PR is finished, please review, thanks.

@deadprogram
Copy link
Member

Hello @TeCHiScy thank you for the PR.

Could you please rebase against the latest dev branch? It should then be able to pass all of the tests without a problem, from how it looks.

Thanks!

@TeCHiScy
Copy link
Contributor Author

TeCHiScy commented Mar 30, 2024

Hello @TeCHiScy thank you for the PR.

Could you please rebase against the latest dev branch? It should then be able to pass all of the tests without a problem, from how it looks.

Thanks!

Done, all checks passed now. @deadprogram

@deadprogram
Copy link
Member

Great thank you @TeCHiScy for the quick response. Now merging.

@deadprogram deadprogram merged commit 6f00c32 into hybridgroup:dev Mar 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants