Filestorage roadmap milestone #1204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: deadprogram <ron@hybridgroup.com>
Signed-off-by: deadprogram <ron@hybridgroup.com>
…t results on macOS. See https://forum.opencv.org/t/match-template-different-results-on-mac-m1/10026 and other similar issues. Signed-off-by: deadprogram <ron@hybridgroup.com>
|
Hello @diegohce Thank you very much for working on this set of features! I notice that this PR seems to have picked up bunch of commits that are in the One way to address this might be to create a new branch from What do you think? |
|
Hi Ron.
Don't know how to do that. I understand that commit messages got dirty but
is it necessary to do that?
…On Sat, Aug 24, 2024 at 6:02 AM Ron Evans ***@***.***> wrote:
Hello @diegohce <https://github.com/diegohce>
Thank you very much for working on this set of features!
I notice that this PR seems to have picked up bunch of commits that are in
the dev branch. Perhaps you should have started with the latest dev
branch?
One way to address this might be to create a new branch from dev, then git
cherry-pick the specific commits for filestorage into that branch, and
open a new PR from that branch to dev.
What do you think?
—
Reply to this email directly, view it on GitHub
<#1204 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADJCC6CFBGSVTJDLNRZEKT3ZTBDY7AVCNFSM6AAAAABNAYMNPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBYGIZTENBSGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yes, because we need to keep the commit log clean. You might be better off just creating a new PR based on |
|
ok
…On Mon, Aug 26, 2024 at 4:59 AM Ron Evans ***@***.***> wrote:
is it necessary to do that?
Yes, because we need to keep the commit log clean. You might be better off
just creating a new PR based on dev and manually adding the new files in
a single new commit.
—
Reply to this email directly, view it on GitHub
<#1204 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADJCC6C4JVUM3ZVOIDNKNI3ZTLN7PAVCNFSM6AAAAABNAYMNPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBZGU4DQMRRGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
done. checks are running as I write this..
…On Mon, Aug 26, 2024 at 11:56 PM Diego Cena ***@***.***> wrote:
ok
On Mon, Aug 26, 2024 at 4:59 AM Ron Evans ***@***.***>
wrote:
> is it necessary to do that?
>
> Yes, because we need to keep the commit log clean. You might be better
> off just creating a new PR based on dev and manually adding the new
> files in a single new commit.
>
> —
> Reply to this email directly, view it on GitHub
> <#1204 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ADJCC6C4JVUM3ZVOIDNKNI3ZTLN7PAVCNFSM6AAAAABNAYMNPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBZGU4DQMRRGU>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filestorage roadmap milestone