You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently periods are rewritten to slashes when accessing route keys, this is so that dot notation can be used, which provides familiarity to those coming from Laravel where that's the convention for route names.
However, this leads to severe issues when there are actually periods in the URL. For example: http://localhost:8080/docs/1.x/index.html would be parsed as http://localhost:8080/docs/1/x/index.html which results in Route [docs/1/x/index] not found.
This then begs the question if we should support normalizing route keys to support dot notation at all, especially since I think it's a fairly common use case to use HydePHP for documentation sites, which are often versioned like this. Furthermore, periods are allowed in URLs.
It also adds complexity to have multiple route key namings, and since route keys are directly tied to the URL routes I think it makes more sense to only use that format.
Currently periods are rewritten to slashes when accessing route keys, this is so that dot notation can be used, which provides familiarity to those coming from Laravel where that's the convention for route names.
However, this leads to severe issues when there are actually periods in the URL. For example:
http://localhost:8080/docs/1.x/index.html
would be parsed ashttp://localhost:8080/docs/1/x/index.html
which results inRoute [docs/1/x/index] not found.
This then begs the question if we should support normalizing route keys to support dot notation at all, especially since I think it's a fairly common use case to use HydePHP for documentation sites, which are often versioned like this. Furthermore, periods are allowed in URLs.
It also adds complexity to have multiple route key namings, and since route keys are directly tied to the URL routes I think it makes more sense to only use that format.
See #1239
The text was updated successfully, but these errors were encountered: