-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Should we add a version prefix to the generator string? #1748
Comments
HTML spec states that the value is freeform, but for all CMSs I'm seeing with a quick search, noone seems to use a version prefix. |
Got some very good recommendations by ChatGPT 4 after non-directive questioning.
Since we use a "v" prefix pretty much everywhere, this makes sense for us to keep this the same. On a follow up on which is most common:
Claude also favours prefixless
Using AI like this gives good insight into what is statistically likley to be a good choice. However, since this is not a standardised format, I don't think external parsers is something we need to worry about. It's more for curious humans. And for that reason I think it could be good if we matched how we always present versions, with the prefix. |
Another note is that many generators use just the major version (very sound for dynamic things that can have vulnerabilities), but I don't think that's useful here since there aren't that many major versions at this time... |
Given this is mainly for human use, and a since we use the version prefix everywhere else, I'm going to go with my gut and go against the existing conventions here, and move forward with this. |
I LOVE that I've been debating this forwards and backwards, whilst completley forgetting I already fixed this last year in eade477 https://github.com/hydephp/develop/releases/tag/v1.0.0-RC.6 The reason I must have spaced on this is that this is set in a config value, so HydePHP.com has not updated fully, but new projects have this since a long time back. So what we definitely should do is to update the sitemap generator to normalize with this. I checked, and since the |
Both in HTML pages and the sitemap generator we have this:
Maybe we should prefix them like this?
I think it looks nicer, but we should check what the conventions are.
The text was updated successfully, but these errors were encountered: