Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AppServiceProvider.php #5

Closed
Tracked by #4
caendesilva opened this issue Jun 8, 2022 · 0 comments
Closed
Tracked by #4

Remove AppServiceProvider.php #5

caendesilva opened this issue Jun 8, 2022 · 0 comments

Comments

@caendesilva
Copy link
Member

The AppServiceProvider is not needed, and only handles changing the logo to a temporary one with the Ukrainian flag colours which can be handled in other places. The only benefit I see that it brings is that it gives a good point to configure application internals as it makes it clear that Hyde does in fact support service providers just the same a Laravel. Though I think this can easily be explained in documentation. And it does not fit in the 80% use case, and so I do not think it's worth having an entire directory that provides no real value to the majority of uses.

caendesilva added a commit that referenced this issue Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant