Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Search.html is not resolving app styles when using a custom output path #93

Closed
caendesilva opened this issue Jun 23, 2022 · 1 comment
Assignees

Comments

@caendesilva
Copy link
Member

Reproduce:

Set 'output_directory' => '', in the docs config, build the site, visit search.html, there are no styles. Probably due to improper configuration/passing of the current page variable when rendering the page.

@caendesilva
Copy link
Member Author

Fixed in upcoming release

caendesilva added a commit that referenced this issue Jun 24, 2022
## v0.42.0-beta - 2022-06-24

### Added
- Added a `@section` hook to the docs layout to allow yielding content
- HydeRC: Add ping route to check if a HydeRC server is running hydephp/realtime-compiler#9
- internal: Added an HtmlResponse object to the realtime compiler

### Changed
- Change the the Prettier integration to only modify HTML files #102
- Change how the `docs/search.html` page is rendered, by handling page logic in the view, to decouple it from the build search command

### Fixed
- HydeRC: Rewrite request docs to docs/index to fix hydephp/realtime-compiler#10
- Fix bug #93 where styles were missing on search.html when changing the output directory to root
caendesilva pushed a commit to hydephp/hyde that referenced this issue Jun 24, 2022
## v0.42.0-beta - 2022-06-24

### Added
- Added a  hook to the docs layout to allow yielding content
- HydeRC: Add ping route to check if a HydeRC server is running hydephp/realtime-compiler#9
- internal: Added an HtmlResponse object to the realtime compiler

### Changed
- Change the the Prettier integration to only modify HTML files hydephp/develop#102
- Change how the  page is rendered, by handling page logic in the view, to decouple it from the build search command

### Fixed
- HydeRC: Rewrite request docs to docs/index to fix hydephp/realtime-compiler#10
- Fix bug hydephp/develop#93 where styles were missing on search.html when changing the output directory to root hydephp/develop@84f4cbb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant