Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated internal AssetManager trait #111

Merged
merged 3 commits into from
Jun 25, 2022

Conversation

caendesilva
Copy link
Member

This trait offloaded methods for the Hyde facade class. This will thus remove the following methods:

Hyde::assetManager()
Hyde::styles()
Hyde::scripts()

@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #111 (640a95b) into master (c7ffb61) will increase coverage by 0.30%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #111      +/-   ##
============================================
+ Coverage     98.92%   99.23%   +0.30%     
+ Complexity      752      749       -3     
============================================
  Files            98       97       -1     
  Lines          1958     1952       -6     
============================================
  Hits           1937     1937              
+ Misses           21       15       -6     
Impacted Files Coverage Δ
packages/framework/src/Hyde.php 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7ffb61...640a95b. Read the comment docs.

@caendesilva caendesilva marked this pull request as ready for review June 25, 2022 11:49
@caendesilva caendesilva merged commit 194e0fc into master Jun 25, 2022
@caendesilva caendesilva deleted the remove-deprecated-internal-assetmanager-trait branch June 25, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant