Finalize the asset service #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1186 +/- ##
=============================================
Coverage 100.00% 100.00%
- Complexity 1353 2702 +1349
=============================================
Files 156 312 +156
Lines 3527 7056 +3529
=============================================
+ Hits 3527 7056 +3529
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Changed to normalize config setting names, as similar options also use the verb form.
caendesilva
force-pushed
the
finalize-asset-service
branch
from
5fb274f to
8d8dacc
Compare
There is already a convenient place to set this property, using the config value in the constructor, and there is a public accessor method.
caendesilva
force-pushed
the
finalize-asset-service
branch
from
48fd5c7 to
3ab44e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Polishes and finalizes the asset service in preparation for the 1.0 release.
Breaking changes
Contains the following breaking changes:
Rename
hyde.cache_bustingtohyde.enable_cache_bustingThe following options were considered:
Of the three options provided, I would recommend using enable_cache_busting as the name for the configuration option that controls whether cache busting is applied.
This is because the term "enable" clearly indicates that the option is a boolean toggle that turns a feature on or off. The term "cache_busting" is also clear and concise, making it easy for users to understand what the option does.
The option use_cache_busting is also a reasonable alternative, but it is slightly less clear in its meaning. It could be interpreted as indicating that the feature is always on, and the option is simply selecting which type of cache busting to use.
Lastly, cache_busting on its own is too ambiguous and does not clearly indicate whether the feature is enabled or disabled. It also does not provide any indication of what the option does or how it affects the behavior of the system.
Make public
AssetService::$versionproperty protectedThere is already a convenient place to set this property, using the config value in the constructor, and there is a public accessor method.