Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused $withoutNavigation variable from the app layout #119

Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jul 1, 2022

I think this was a layover when using the app layout as the base for the documentation site. Now that the docs are in a separate layout we aren't using it. Resolves #118

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #119 (4264c84) into master (3f47465) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #119      +/-   ##
============================================
- Coverage     99.23%   99.12%   -0.11%     
  Complexity      749      749              
============================================
  Files            97       97              
  Lines          1952     1952              
============================================
- Hits           1937     1935       -2     
- Misses           15       17       +2     
Impacted Files Coverage Δ
...s/framework/src/Actions/ConvertsFooterMarkdown.php 0.00% <0.00%> (-100.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f47465...4264c84. Read the comment docs.

@caendesilva caendesilva merged commit 350db6d into master Jul 1, 2022
@caendesilva caendesilva deleted the remove-withoutNavigation-variable-from-blade-views branch July 1, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is $withoutNavigation in the app layout still used, or can we remove it?
1 participant