Finalize foundation collections

[caendesilva]

Abstract

Polishes and finalizes the foundation collections in preparation for the 1.0 release.

Issues

• Fixes Remove the BaseFoundationCollection::getInstance as it adds no value #1199
• Fixes Catch and rethrow exceptions during discovery using a helpful message #1194
• Fixes Add FileCollection::addFile method to match addPage and addRoute in the other collections  #1200
• Fixes Add FileCollection::getFiles method to match getPages and getRoutes in the other collections #1196

Breaking/significant changes

• Moves collection accessors to the facade classes to limit scope of the classes to focus on data discovery
• Make the BaseFoundationCollection::boot method final
• Change BaseFoundationCollection::runDiscovery to return void instead of self
• Change BaseFoundationCollection::runExtensionCallbacks to return void instead of self
• Make FileCollection::addFile method return void
• Make PageCollection::addPage method return void
• Make RouteCollection::addRoute method return void

[codecov]

Codecov Report

Merging #1193 (5062f4b) into master (dc8e759) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##              master     #1193     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1347      2690   +1343     
=============================================
  Files            156       312    +156     
  Lines           3524      7024   +3500     
=============================================
+ Hits            3524      7024   +3500     

Impacted Files	Coverage Δ
...undation/Concerns/HandlesFoundationCollections.php	100.00% <ø> (ø)
...c/Foundation/Concerns/BaseFoundationCollection.php	100.00% <100.00%> (ø)
...ackages/framework/src/Foundation/Facades/Files.php	100.00% <100.00%> (ø)
...ackages/framework/src/Foundation/Facades/Pages.php	100.00% <100.00%> (ø)
...ckages/framework/src/Foundation/Facades/Routes.php	100.00% <100.00%> (ø)
...framework/src/Foundation/Kernel/FileCollection.php	100.00% <100.00%> (ø)
...framework/src/Foundation/Kernel/PageCollection.php	100.00% <100.00%> (ø)
...ramework/src/Foundation/Kernel/RouteCollection.php	100.00% <100.00%> (ø)
.../framework/src/Framework/Services/BuildService.php	100.00% <100.00%> (ø)
packages/framework/src/Pages/Concerns/HydePage.php	100.00% <100.00%> (ø)
... and 156 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.