Improve Hyde title generation helper #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caendesilva
changed the title
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
============================================
- Coverage 99.12% 99.02% -0.11%
- Complexity 749 750 +1
============================================
Files 97 97
Lines 1952 1956 +4
============================================
+ Hits 1935 1937 +2
- Misses 17 19 +2
Continue to review full report at Codecov.
|
caendesilva
deleted the
117-style-bug-hyde-title-parser-should-not-capitalize-non-principal-words
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Hyde::titleFromSlug() helper is internally moved and is referenced through the new Hyde::makeTitle() helper which is an improved version, with a more general name. This is done by replacing the underlying implementation to use the Str::headline() helper instead of Str::title(), combined with a lookup table of auxiliary words that should be lowercase, while ensuring the first word is always capitalized.
The helper does not support fully uppercase input, which is okay since it is mainly intended to convert slugs to titles, as a fallback. I think it may be out of scope to parse uppercase input Hyde source filenames are recommended to be lowercase, but am open to change if requested.