-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize discovery service #1203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56c7043
to
0e80845
Compare
Codecov Report
@@ Coverage Diff @@
## master #1203 +/- ##
=============================================
Coverage 100.00% 100.00%
- Complexity 1343 2662 +1319
=============================================
Files 155 310 +155
Lines 3507 6970 +3463
=============================================
+ Hits 3507 6970 +3463
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
45db6f7
to
af7ecc7
Compare
af7ecc7
to
fa63b1b
Compare
Normalization is covered by called method
fa170a5
to
f251d35
Compare
f251d35
to
558f9f4
Compare
e5541d1
to
b40abdc
Compare
285a258
to
1f8f3c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Polishes the DiscoveryService class before the 1.0 release. Contains quite a few breaking changes as this class is very old and a lot of its responsibilities have shifted to other locations.
Breaking changes
Almost the entire class is rewritten.
DiscoveryService::getBladePageFiles()
withBladePage::files()
DiscoveryService::getMarkdownPageFiles()
withMarkdownPage::files()
DiscoveryService::getMarkdownPostFiles()
withMarkdownPost::files()
DiscoveryService::getDocumentationPageFiles()
withDocumentationPage::files()
getSourceFileListForModel
togetModelIdentifiers