Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize discovery service #1203

Merged
merged 50 commits into from
Mar 4, 2023
Merged

Finalize discovery service #1203

merged 50 commits into from
Mar 4, 2023

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Mar 4, 2023

Abstract

Polishes the DiscoveryService class before the 1.0 release. Contains quite a few breaking changes as this class is very old and a lot of its responsibilities have shifted to other locations.

Breaking changes

Almost the entire class is rewritten.

  • Replaced method DiscoveryService::getBladePageFiles() with BladePage::files()
  • Replaced method DiscoveryService::getMarkdownPageFiles() with MarkdownPage::files()
  • Replaced method DiscoveryService::getMarkdownPostFiles() with MarkdownPost::files()
  • Replaced method DiscoveryService::getDocumentationPageFiles() with DocumentationPage::files()
  • Rename method getSourceFileListForModel to getModelIdentifiers
  • Remove unused method DiscoveryService::getModelFileExtension
  • Inline and remove method DiscoveryService::getModelFileExtension
  • Inline and remove method DiscoveryService::getModelIdentifiers
  • Remove support for media extensions supplied in config as string

@caendesilva caendesilva mentioned this pull request Mar 4, 2023
26 tasks
@caendesilva caendesilva force-pushed the finalize-discovery-service branch from 56c7043 to 0e80845 Compare March 4, 2023 13:18
@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #1203 (285a258) into master (798d58b) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 285a258 differs from pull request most recent head 1f8f3c9. Consider uploading reports for the commit 1f8f3c9 to get more accurate results

@@              Coverage Diff              @@
##              master     #1203     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1343      2662   +1319     
=============================================
  Files            155       310    +155     
  Lines           3507      6970   +3463     
=============================================
+ Hits            3507      6970   +3463     
Impacted Files Coverage Δ
packages/framework/src/Facades/Features.php 100.00% <100.00%> (ø)
...ges/framework/src/Foundation/Kernel/Filesystem.php 100.00% <100.00%> (ø)
...mework/src/Framework/Services/DiscoveryService.php 100.00% <100.00%> (ø)
...ework/src/Framework/Services/ValidationService.php 100.00% <100.00%> (ø)
packages/framework/src/Pages/Concerns/HydePage.php 100.00% <100.00%> (ø)
.../packages/framework/src/Support/Facades/Render.php 100.00% <0.00%> (ø)
...amework/src/Framework/Services/ViewDiffService.php 100.00% <0.00%> (ø)
...amework/Actions/PostBuildTasks/GenerateRssFeed.php 100.00% <0.00%> (ø)
.../framework/src/Framework/Services/BuildService.php 100.00% <0.00%> (ø)
...ework/src/Console/Commands/BuildRssFeedCommand.php 100.00% <0.00%> (ø)
... and 150 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva force-pushed the finalize-discovery-service branch 3 times, most recently from 45db6f7 to af7ecc7 Compare March 4, 2023 13:39
@caendesilva caendesilva force-pushed the finalize-discovery-service branch from af7ecc7 to fa63b1b Compare March 4, 2023 13:39
@caendesilva caendesilva force-pushed the finalize-discovery-service branch from fa170a5 to f251d35 Compare March 4, 2023 14:46
@caendesilva caendesilva force-pushed the finalize-discovery-service branch from f251d35 to 558f9f4 Compare March 4, 2023 14:48
@caendesilva caendesilva force-pushed the finalize-discovery-service branch from e5541d1 to b40abdc Compare March 4, 2023 14:53
@caendesilva caendesilva force-pushed the finalize-discovery-service branch from 285a258 to 1f8f3c9 Compare March 4, 2023 15:12
@caendesilva caendesilva marked this pull request as ready for review March 4, 2023 15:16
@caendesilva caendesilva merged commit a9db051 into master Mar 4, 2023
@caendesilva caendesilva deleted the finalize-discovery-service branch March 4, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants