Remove deprecated HydePage::$canonicalUrl property
#1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1256 +/- ##
=============================================
Coverage 100.00% 100.00%
- Complexity 1317 2632 +1315
=============================================
Files 152 304 +152
Lines 3459 6908 +3449
=============================================
+ Hits 3459 6908 +3449
... and 152 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
caendesilva
force-pushed
the
remove-deprecated-canonicalUrl-field
branch
from
257bb44 to
013bf0e
Compare
This reverts commit 84869ba.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that the internal data state should be as portable as possible. Having a canonicalUrl as part of the internal data structure breaks this portability as it is in many cases entirely dependent on the environment the data is used in. This means that it should not be part of the internal data structure, nor its serialized form. It's much better suited as a runtime accessor method. Thus, this PR removes the deprecated property, and replaces it with a new public method that uses the same logic ported from the page factory creator so the end result is still the same.