Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move page models into new Models\Pages namespace to make them more distinct from auxiliary helper models #130

Merged
merged 8 commits into from
Jul 2, 2022

Conversation

caendesilva
Copy link
Member

  • Moved Hyde\Framework\Models\BladePage to new namespace Hyde\Framework\Models\Pages\BladePage
  • Moved Hyde\Framework\Models\MarkdownPage to new namespace Hyde\Framework\Models\Pages\MarkdownPage
  • Moved Hyde\Framework\Models\MarkdownPost to new namespace Hyde\Framework\Models\Pages\MarkdownPost
  • Moved Hyde\Framework\Models\DocumentationPage to new namespace Hyde\Framework\Models\Pages\DocumentationPage

@codecov
Copy link

codecov bot commented Jul 2, 2022

Codecov Report

Merging #130 (7b60041) into master (df2e05c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #130   +/-   ##
=========================================
  Coverage     99.14%   99.14%           
  Complexity      763      763           
=========================================
  Files            98       98           
  Lines          1979     1979           
=========================================
  Hits           1962     1962           
  Misses           17       17           
Impacted Files Coverage Δ
...framework/src/Actions/CreatesNewPageSourceFile.php 100.00% <ø> (ø)
.../Actions/GeneratesDocumentationSearchIndexFile.php 100.00% <ø> (ø)
...mework/src/Commands/HydeBuildStaticSiteCommand.php 100.00% <ø> (ø)
...ges/framework/src/Commands/HydeMakePageCommand.php 100.00% <ø> (ø)
...src/Concerns/FacadeHelpers/HydeSmartDocsFacade.php 100.00% <ø> (ø)
...s/framework/src/Concerns/GeneratesPageMetadata.php 100.00% <ø> (ø)
...ackages/framework/src/Concerns/HasPageMetadata.php 100.00% <ø> (ø)
...es/framework/src/Concerns/Internal/FileHelpers.php 91.11% <ø> (ø)
...mework/src/Concerns/Internal/FluentPathHelpers.php 100.00% <ø> (ø)
...cerns/Markdown/HasConfigurableMarkdownFeatures.php 100.00% <ø> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df2e05c...7b60041. Read the comment docs.

@caendesilva caendesilva marked this pull request as ready for review July 2, 2022 15:29
@caendesilva caendesilva merged commit 46eb163 into master Jul 2, 2022
@caendesilva caendesilva deleted the move-pagemodels-into-namespace branch July 2, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants