Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal HydeFronts automation scripts to lint and handle releases and versions #1360

Merged
merged 56 commits into from
Mar 27, 2023

Conversation

caendesilva
Copy link
Member

Adds an internal HydeFront post-build script to make sure the version strings are up to date, which can be run as part of the build process, or as a linter. The PR also removes the version injection from the Yaml workflows as those are harder to keep up to date since they aren't very coupled to HydeFront. Speaking of coupling, this also removes the specific hardcoded CSS version test in the HydeRC test, so it is decoupled as it's outside the test scope.

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #1360 (49d9fec) into master (9222130) will not change coverage.
The diff coverage is n/a.

❗ Current head 49d9fec differs from pull request most recent head 2f800b4. Consider uploading reports for the commit 2f800b4 to get more accurate results

@@             Coverage Diff             @@
##             master    #1360     +/-   ##
===========================================
  Coverage     99.97%   99.97%             
- Complexity     1338     2676   +1338     
===========================================
  Files           152      304    +152     
  Lines          3489     6978   +3489     
===========================================
+ Hits           3488     6976   +3488     
- Misses            1        2      +1     

see 152 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

caendesilva added a commit to hydephp/hydefront that referenced this pull request Mar 27, 2023
Manually merges these, both to test them, and since the monorepo splitter is not allowed to modify workflows, for security reasons.
caendesilva added a commit to hydephp/hydefront that referenced this pull request Mar 27, 2023
@caendesilva caendesilva changed the title Add internal HydeFront post-build script Add internal HydeFront automation scripts to lint and handle releases and versions Mar 27, 2023
caendesilva added a commit to hydephp/hydefront that referenced this pull request Mar 27, 2023
@caendesilva caendesilva changed the title Add internal HydeFront automation scripts to lint and handle releases and versions Add internal HydeFronts automation scripts to lint and handle releases and versions Mar 27, 2023
@caendesilva caendesilva marked this pull request as ready for review March 27, 2023 20:28
@caendesilva caendesilva merged commit 2aed568 into master Mar 27, 2023
@caendesilva caendesilva deleted the add-internal-hydefront-post-build-script branch March 27, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant