Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change HydePage return types to static #1371

Merged
merged 1 commit into from
May 8, 2023

Conversation

caendesilva
Copy link
Member

Gives better IDE support, and unifies the class return types as other methods also return static.

Gives better IDE support, and unifies the class return types as other methods also return static.
@caendesilva caendesilva marked this pull request as ready for review May 7, 2023 19:15
@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Merging #1371 (e11f339) into master (9797b89) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             master    #1371     +/-   ##
===========================================
  Coverage     99.97%   99.97%             
- Complexity     1339     2678   +1339     
===========================================
  Files           152      304    +152     
  Lines          3489     6978   +3489     
===========================================
+ Hits           3488     6976   +3488     
- Misses            1        2      +1     
Impacted Files Coverage Δ
packages/framework/src/Pages/Concerns/HydePage.php 100.00% <100.00%> (ø)

... and 152 files with indirect coverage changes

@caendesilva caendesilva merged commit bb88a9b into master May 8, 2023
@caendesilva caendesilva deleted the change-hydepage-return-types-to-static branch May 8, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant