Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated DocumentationPage::getDocumentationOutputPath() #165

Merged
merged 3 commits into from
Jul 3, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jul 3, 2022

This method has been replaced with DocumentationPage::getOutputPath()

caendesilva and others added 3 commits July 3, 2022 19:17
Makes the implementation the same of the getDocumentationOutputPath method that is being removed
@codecov
Copy link

codecov bot commented Jul 3, 2022

Codecov Report

Merging #165 (e396069) into master (acb3def) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #165   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity       752       751    -1     
===========================================
  Files             97        97           
  Lines           1951      1949    -2     
===========================================
- Hits            1951      1949    -2     
Impacted Files Coverage Δ
...s/framework/src/Models/Pages/DocumentationPage.php 100.00% <ø> (ø)
packages/framework/src/HydeServiceProvider.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb3def...e396069. Read the comment docs.

@caendesilva caendesilva merged commit 21e8e49 into master Jul 3, 2022
@caendesilva caendesilva deleted the remove-deprecated-getDocumentationOutputPath branch July 3, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants