Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Try to fix Codecov #1657

Merged
merged 4 commits into from
Apr 14, 2024
Merged

Internal: Try to fix Codecov #1657

merged 4 commits into from
Apr 14, 2024

Conversation

caendesilva
Copy link
Member

Tries to fix Codecov, again.

@github-actions github-actions bot added the internal This pull request does not affect package code label Apr 12, 2024
@caendesilva caendesilva marked this pull request as ready for review April 12, 2024 18:27
@caendesilva
Copy link
Member Author

Codecov really seems to be broken. They want me to use a token, but I can't add a token because it refuses to let me log in as the organisation even though they have all the permissions they need. Reinstalling the GitHub App does nothing for them to realise that I should be able to manage the organisation on Codecov.

@caendesilva caendesilva deleted the try-to-fix-codecov-again branch April 12, 2024 18:28
@caendesilva caendesilva restored the try-to-fix-codecov-again branch April 14, 2024 10:20
@caendesilva
Copy link
Member Author

Reopening as they now seem to have given me access to the org

@caendesilva caendesilva reopened this Apr 14, 2024
@caendesilva caendesilva force-pushed the try-to-fix-codecov-again branch from e086490 to 4c05fb6 Compare April 14, 2024 10:31
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (e81d59f) to head (4c05fb6).
Report is 74 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1657      +/-   ##
============================================
- Coverage     99.64%   99.63%   -0.01%     
- Complexity     1747     1752       +5     
============================================
  Files           181      182       +1     
  Lines          4728     4683      -45     
============================================
- Hits           4711     4666      -45     
  Misses           17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva merged commit 11d8848 into master Apr 14, 2024
20 checks passed
@caendesilva caendesilva deleted the try-to-fix-codecov-again branch April 14, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal This pull request does not affect package code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant