-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.x] Honour front matter navigation groups set in front matter regardless of subdirectory setting #1703
[1.x] Honour front matter navigation groups set in front matter regardless of subdirectory setting #1703
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1703 +/- ##
=========================================
Coverage 99.97% 99.97%
- Complexity 1742 1745 +3
=========================================
Files 181 181
Lines 4657 4661 +4
=========================================
+ Hits 4656 4660 +4
Misses 1 1 ☔ View full report in Codecov by Sentry. |
This reverts commit c0ada2c as added logic has no effect since we fall back to this at the end of the method.
72bec82
to
4884ea5
Compare
4884ea5
to
917dcb3
Compare
This pull request fixes #1515, which concerns the inconsistency in navigation group behavior when setting navigation groups for standard pages in front matter alongside the dropdown subdirectory setting in the configuration file.
Using the following in
_pages/page.md
will now cause the page to be put in the appropriate dropdown regardless of thehyde.navigation.subdirectories
setting. This better follows the principle of least astonishment as setting the front matter is an explicit instruction to HydePHP.