Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined array key exception for empty Markdown pages #1728

Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jun 13, 2024

Bumps the front matter parser to use spatie/yaml-front-matter#41, thus fixing #1705. Also adds a test to proof it.

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (4e1b97e) to head (7fd4aa2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1728   +/-   ##
=========================================
  Coverage     99.97%   99.97%           
  Complexity     1746     1746           
=========================================
  Files           181      181           
  Lines          4667     4667           
=========================================
  Hits           4666     4666           
  Misses            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva force-pushed the fix-undefined-array-key-exception-for-empty-markdown-pages branch from 467012b to 7fd4aa2 Compare June 13, 2024 11:36
@caendesilva caendesilva marked this pull request as ready for review June 13, 2024 11:36
@caendesilva caendesilva merged commit f985751 into master Jun 13, 2024
21 checks passed
@caendesilva caendesilva deleted the fix-undefined-array-key-exception-for-empty-markdown-pages branch June 13, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined array key exception when creating Markdown pages with only front matter and no Markdown
1 participant