Patch TailwindCSS table issue in HydeFront #1766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmadesilva
added
the
run-visual-tests
Member
Author
Not needed since since we have not pushed any fault change, and this will be compatible with past versions, so a patch release is fine. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1766 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 1750 1750
===========================================
Files 180 180
Lines 4674 4674
===========================================
Hits 4674 4674 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Visual change confirmed
|
emmadesilva
force-pushed
the
patch-tailwindcss-in-hydefront
branch
from
9212252 to
dff834e
Compare
emmadesilva
force-pushed
the
patch-tailwindcss-in-hydefront
branch
from
dff834e to
0f8d7e4
Compare
github-actions
bot
removed
the
run-visual-tests
Member
Author
|
tailwindlabs/tailwindcss-typography#346 is merged so we can bump the version and revert the patch tailwindlabs/tailwindcss-typography#346 (comment) |
emmadesilva
added a commit
that referenced
this pull request
Nov 17, 2024
Revert "Patch TailwindCSS table issue in HydeFront" #1766
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since no progress is being made on tailwindlabs/tailwindcss-typography#346 being merged, and this issue is halting releasing HydePHP v1.7 (in #1689) due to the visual BC break, this PR patches the issue through HydeFront.
It also compiles the Tailwind and HydeFront (superseding #1689) and issues HydeFront v3.3.5 which is a patch version bump.
It also issues a minor version bump to ensure the CDN loads the new version.