-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the Yaml configuration loader #1770
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1770 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 1750 1758 +8
===========================================
Files 180 180
Lines 4674 4689 +15
===========================================
+ Hits 4674 4689 +15 ☔ View full report in Codecov by Sentry. |
06aff63
to
e4e744a
Compare
e4e744a
to
0b7b339
Compare
Squashed commit of the following: commit 2b9d8d1 Author: Caen De Silva <caen@desilva.se> Date: Fri Apr 26 15:35:17 2024 +0200 Refactor internal config handling to use a property commit 5af1fea Author: Caen De Silva <caen@desilva.se> Date: Fri Apr 26 13:18:21 2024 +0200 Introduce local variable commit f12314a Author: Caen De Silva <caen@desilva.se> Date: Fri Apr 26 13:11:21 2024 +0200 Configure site name environment variable from Yaml config commit 7942491 Author: Caen De Silva <caen@desilva.se> Date: Fri Apr 26 13:04:06 2024 +0200 Draft new method to merge environment variables commit d32d688 Author: Caen De Silva <caen@desilva.se> Date: Fri Apr 26 13:00:14 2024 +0200 Introduce property for the loaded data commit 301a9bc Author: Caen De Silva <caen@desilva.se> Date: Fri Apr 26 12:56:49 2024 +0200 Skip the failing tests commit 65b2a05 Author: Caen De Silva <caen@desilva.se> Date: Fri Apr 26 12:55:55 2024 +0200 Add todo commit ebe9146 Author: Caen De Silva <caen@desilva.se> Date: Fri Apr 26 12:52:00 2024 +0200 Test setting site name merges sidebar header commit 3e02dc5 Author: Caen De Silva <caen@desilva.se> Date: Fri Apr 26 12:45:50 2024 +0200 Create failing test commit 2f18f95 Author: Caen De Silva <caen@desilva.se> Date: Fri Apr 26 12:44:33 2024 +0200 Draft initial tests
This reverts commit b695a5d.
b91232c
to
4eb35db
Compare
It's an internal interface, so I don't want to properly implement it. And yes, the class is named that, it was fixed in laravel-zero/framework#495
Seems to not have any effect on outcome, but is simpler, so let's go for it.
566b146
to
d8bcfcd
Compare
96e92a5
to
6856110
Compare
packages/framework/src/Foundation/Internal/LoadYamlConfiguration.php
Outdated
Show resolved
Hide resolved
This reverts commit 40cb96f.
This reverts commit 8a22eaa.
…nt variable" This reverts commit 4af6d03. See #1770 (comment)
Unless this is modified to another pattern, we should also support this
And of course this
I think these are all the remaining ones |
It's a bit hard to test, but I confirmed manually that setting the site name in the environment variables, that takes precedence over all this, as those are evaluated before this. |
31bf372
to
32e3772
Compare
Not sure how we can set this, since it's not keyed. Edit: We can probably loop through the array, but this is starting to get complex. I think adding a dedicated environment configuration loader to get data from the Yaml file could work if it's in between the environment and configuration loaders |
Overview: