Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link component to resolve routes automatically #225

Merged
merged 12 commits into from
Jul 15, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jul 15, 2022

Adds an <x-link /> component that hooks into the View factory to resolve relative links automatically. No more having to pass the $currentPage property to a bunch of relativeLink helpers!

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #225 (da06c2c) into master (abcf759) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #225   +/-   ##
=========================================
  Coverage     99.90%   99.90%           
- Complexity      811      813    +2     
=========================================
  Files           103      104    +1     
  Lines          2080     2085    +5     
=========================================
+ Hits           2078     2083    +5     
  Misses            2        2           
Impacted Files Coverage Δ
packages/framework/src/HydeServiceProvider.php 100.00% <100.00%> (ø)
...s/framework/src/Views/Components/LinkComponent.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abcf759...da06c2c. Read the comment docs.

@caendesilva caendesilva merged commit be56398 into master Jul 15, 2022
@caendesilva caendesilva deleted the add-a-link-component branch July 15, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant