Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Router class to Services\RoutingService #234

Merged
merged 3 commits into from
Jul 16, 2022
Merged

Conversation

caendesilva
Copy link
Member

This breaking internal change renames the Router class (and its interface) to RoutingService, to distinguish that it's not a traditional router. It's also moved into the Services namespace.

@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #234 (15a7a9c) into master (a026858) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #234   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       816       816           
===========================================
  Files            103       103           
  Lines           2092      2092           
===========================================
  Hits            2092      2092           
Impacted Files Coverage Δ
packages/framework/src/Services/RoutingService.php 100.00% <ø> (ø)
packages/framework/src/Models/NavigationMenu.php 100.00% <100.00%> (ø)
packages/framework/src/Models/Route.php 100.00% <100.00%> (ø)
packages/framework/src/Services/BuildService.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a026858...15a7a9c. Read the comment docs.

@caendesilva caendesilva merged commit bee5548 into master Jul 16, 2022
@caendesilva caendesilva deleted the rename-router branch July 16, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant