Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _includes directory for quickly adding automatic snippets #245

Merged
merged 24 commits into from
Jul 18, 2022
Merged

Add _includes directory for quickly adding automatic snippets #245

merged 24 commits into from
Jul 18, 2022

Conversation

caendesilva
Copy link
Member

No description provided.

@caendesilva caendesilva linked an issue Jul 18, 2022 that may be closed by this pull request
Add _includes directory for quickly adding automatic snippets #29
Closed
@codecov
Copy link

codecov bot commented Jul 18, 2022 •
edited
Loading

Codecov Report

Merging #245 (6eca5d6) into master (0420a36) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #245   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       802       812   +10     
===========================================
  Files            102       103    +1     
  Lines           2022      2045   +23     
===========================================
+ Hits            2022      2045   +23
Impacted Files Coverage Δ
packages/framework/src/Facades/Includes.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0420a36...6eca5d6. Read the comment docs.

caendesilva and others added 21 commits July 18, 2022 17:25
@caendesilva
Create Includes.php
b63cea0
@caendesilva
Merge branch '29-add-_includes-directory-for-quickly-adding-automatic…
5619059 
…-snippets' of github.com:hydephp/develop into 29-add-_includes-directory-for-quickly-adding-automatic-snippets
@caendesilva
Return default
bf44620
@caendesilva
Cleanup code
14c9957
@caendesilva
Add Includes::$includesDirectory
f1e034d
@caendesilva
Implement get() method
cdafcbf
@caendesilva
Implement markdown() method
41e1a6e
@caendesilva
Implement blade() method
a305583
@caendesilva
Normalize input path
7e51a84 
While this does not allow for nested directories, keeping it simple for now.
@StyleCIBot
Apply fixes from StyleCI
b281d73
@caendesilva
Use the Hyde base path
3c409e2
@caendesilva
Create IncludesFacadeTest.php
0b1e128
@caendesilva
Merge branch '29-add-_includes-directory-for-quickly-adding-automatic…
bbe4892 
…-snippets' of github.com:hydephp/develop into 29-add-_includes-directory-for-quickly-adding-automatic-snippets
@StyleCIBot
Apply fixes from StyleCI
4a05e28
@caendesilva
Define path() method
cf608c2
@caendesilva
Implement path() method
e2bfe66
@caendesilva
Use path() method
dcaa790
@caendesilva
Test path() method
9c2cb50
@caendesilva
Create the directory if it does not exist
a785c69
@StyleCIBot
Apply fixes from StyleCI
1431233
@caendesilva
Change argument property $partial to $filename
6eca5d6
@caendesilva caendesilva marked this pull request as ready for review July 18, 2022 16:17
@caendesilva
Copy link
Member Author

Could be neat with an Includes::code() helper to render Torchlight blocks?

@caendesilva caendesilva merged commit cc1802f into master Jul 18, 2022
@caendesilva caendesilva deleted the 29-add-_includes-directory-for-quickly-adding-automatic-snippets branch July 18, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add _includes directory for quickly adding automatic snippets
2 participants
@caendesilva @StyleCIBot