Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test files from Hyde package #282

Merged
merged 5 commits into from
Jul 28, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jul 28, 2022

Building a website with HydePHP is often a bit different than developing a full stack application with Laravel, as with Hyde you mainly focus on content for the frontend. For the majority of use cases, users of the Hyde/Hyde package will not need to run tests (and if they do, they'll likely be with a front end tool like Cypress, instead of PHPUnit/Pest).

Removing these test files from the split package will reduce complexity (and resolve hydephp/hyde#206). Users that need to run tests can with ease set up a suite by installing the framework of their choice. I also added a sample workflow file (the one currently in hyde/hyde what will be removed).

For now, I think the phpunit.dist.xml file can be kept, though I'm removing the Dusk one.

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #282 (a699354) into master (4e9f7e4) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              master      #282   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       814       814           
===========================================
  Files            100       100           
  Lines           2043      2043           
===========================================
  Hits            2043      2043           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e9f7e4...a699354. Read the comment docs.

caendesilva added a commit to hydephp/hyde that referenced this pull request Jul 28, 2022
@caendesilva caendesilva merged commit 5af0a70 into master Jul 28, 2022
@caendesilva caendesilva deleted the remove-test-files-from-hyde-package branch July 28, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Bug: Files set to export-ignore should not be included when generating a repository from the template
1 participant