Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal codebase improvements #291

Merged
merged 9 commits into from
Jul 30, 2022
Merged

Conversation

caendesilva
Copy link
Member

Aiming to fix some issues discovered by Scrutinizer

This is a layover from when this class was not a facade bound into the service container.
Also fixes type error as the value is used in methods not expecting null.
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #291 (f6b8c61) into master (8fb1fca) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #291   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity       811       809    -2     
===========================================
  Files             96        96           
  Lines           2029      2025    -4     
===========================================
- Hits            2029      2025    -4     
Impacted Files Coverage Δ
packages/framework/src/Hyde.php 100.00% <ø> (ø)
packages/framework/src/HydeKernel.php 100.00% <100.00%> (ø)
packages/framework/src/Models/Image.php 100.00% <100.00%> (ø)
...s/framework/src/Views/Components/LinkComponent.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fb1fca...f6b8c61. Read the comment docs.

@caendesilva caendesilva marked this pull request as ready for review July 30, 2022 07:03
@caendesilva caendesilva merged commit 598c15b into master Jul 30, 2022
@caendesilva caendesilva deleted the internal-codebase-improvements branch August 1, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant