-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new URL path helpers #292
Conversation
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 809 813 +4
===========================================
Files 96 96
Lines 2025 2033 +8
===========================================
+ Hits 2025 2033 +8
Continue to review full report at Codecov.
|
This makes so that empty values like `''` also return false
Since the refactor to fully use the new helper will involve the article views I first want to add tests for those. Edit: Done. |
Having a function that can return both a string and a psuedo-boolean (false) can lead to unpredictable states. This PR deprecates the
Hyde::uriPath()
helper and adds two new ones instead,Hyde::qualifiedUrl()
andHyde::hasSiteUrl()
, effectively splitting the former into the latter.