-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Kernel to extract related code into Foundation classes #297
Conversation
…op into kernel-refactor-experiment
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 815 831 +16
===========================================
Files 97 99 +2
Lines 2044 2078 +34
===========================================
+ Hits 2044 2078 +34
Continue to review full report at Codecov.
|
…op into kernel-refactor-experiment
Since all the tests are so scattered into unit tests it's hard to migrate all of them, so I expect there to be some mess as I can't really migrate everything right now. A lot of these are also very old from when I first started learning PHPUnit/Pest, and aren't that great to be honest. Edit, at least some methods have links to the unit tests! Gonna make it a lot easier. |
The goal of this experiment is to extract related code from the HydeKernel, without changing end usage. I'm doing this by creating new foundation classes, and redirecting method calls to them.
This is a rather weird pattern, but it separates logic by concerns, without changing the user experience, which I like.
If this is something that works out, each foundation class should have a test, and a contract (that both the class and the kernel implement)