Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up DiscoveryService #305

Merged
merged 15 commits into from
Jul 31, 2022
Merged

Clean up DiscoveryService #305

merged 15 commits into from
Jul 31, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jul 31, 2022

@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

Merging #305 (f10daa2) into master (5697712) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #305   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       825       825           
===========================================
  Files             99        99           
  Lines           2066      2065    -1     
===========================================
- Hits            2066      2065    -1     
Impacted Files Coverage Δ
packages/framework/src/Foundation/Filesystem.php 100.00% <100.00%> (ø)
...ckages/framework/src/Services/DiscoveryService.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5697712...f10daa2. Read the comment docs.

@caendesilva caendesilva marked this pull request as ready for review July 31, 2022 15:13
@caendesilva caendesilva merged commit 612b24d into master Jul 31, 2022
@caendesilva caendesilva deleted the update-discovery-service branch July 31, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants