Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Reorder AbstractMarkdownPage constructor argument positions, putting the identifier first #329

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Aug 3, 2022

Before

public function __construct(array $matter = [], string $body = '', ?string $title = null, string $identifier = '', ?MarkdownDocument $markdownDocument = null)

After

public function __construct(string $identifier = '', array $matter = [], string $body = '', ?string $title = null, ?MarkdownDocument $markdownDocument = null)

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #329 (1342996) into master (1358bea) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #329   +/-   ##
=========================================
  Coverage     99.85%   99.85%           
  Complexity      825      825           
=========================================
  Files            94       94           
  Lines          2039     2039           
=========================================
  Hits           2036     2036           
  Misses            3        3           
Impacted Files Coverage Δ
...s/framework/src/Contracts/AbstractMarkdownPage.php 100.00% <100.00%> (ø)
...s/framework/src/Models/Pages/DocumentationPage.php 100.00% <100.00%> (ø)
...ckages/framework/src/Models/Pages/MarkdownPost.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva merged commit 4553440 into master Aug 3, 2022
@caendesilva caendesilva deleted the breaking-update-change-model-constructors branch August 3, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant