Discover filesystem upon booting the framework #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
=========================================
Coverage 99.95% 99.95%
- Complexity 884 915 +31
=========================================
Files 99 102 +3
Lines 2191 2259 +68
=========================================
+ Hits 2190 2258 +68
Misses 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Update File.php
Update FileCollection.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Creates a new foundation class, the FileCollection. Which like the other foundation collections, discovers all the files. Running this part of the autodiscovery will further enrich the Hyde Kernel, and allow greater insight into the application. The end user experience should not be affected by this.
It also adds a new model,
File, as an object-oriented way of representing a project file on the disk.Minor note about testing
Note that having the filesystem pre-discovered means that changing the discovery rules at runtime after the framework has booted, means that you need to reboot the framework. I think this would ever really happen during testing when changing a directory mid-test. If it happens in actual code you are probably doing something wrong (registering in boot method instead of register method for example). See this commit where this problem was encountered and addressed.