Skip to content

Move class ConstructsPageSchemas to internal namespace #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 11, 2022
Merged

Move class ConstructsPageSchemas to internal namespace #496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
75afc7c
Move class ConstructsPageSchemas to internal namespace
emmadesilva Sep 11, 2022
8bb50e2
Apply fixes from StyleCI
StyleCIBot Sep 11, 2022
51a2c95
Remove use function
emmadesilva Sep 11, 2022
0824db1
Merge branch 'refactor-hyde-pages' of github.com:hydephp/develop into…
emmadesilva Sep 11, 2022
d84ebd7
Remove use function
emmadesilva Sep 11, 2022
ebdfdea
Reorder properties to match schema
emmadesilva Sep 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/framework/src/Concerns/HydePage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace Hyde\Framework\Concerns;

use Hyde\Framework\Actions\SourceFileParser;
use Hyde\Framework\Concerns\Internal\ConstructsPageSchemas;
use Hyde\Framework\Contracts\CompilableContract;
use Hyde\Framework\Contracts\FrontMatter\PageSchema;
use Hyde\Framework\Contracts\RouteContract;
Expand Down Expand Up @@ -44,8 +45,8 @@ abstract class HydePage implements CompilableContract, PageSchema
public Metadata $metadata;

public string $title;
public ?array $navigation = null;
public ?string $canonicalUrl = null;
public ?array $navigation = null;

public function __construct(string $identifier = '', FrontMatter|array $matter = [])
{
Expand Down
2 changes: 1 addition & 1 deletion ...rk/src/Concerns/ConstructsPageSchemas.php → ...ncerns/Internal/ConstructsPageSchemas.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Hyde\Framework\Concerns;
namespace Hyde\Framework\Concerns\Internal;

use Hyde\Framework\Actions\Constructors\FindsNavigationDataForPage;
use Hyde\Framework\Actions\Constructors\FindsTitleForPage;
Expand Down
2 changes: 1 addition & 1 deletion packages/framework/tests/Feature/HydePageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
* @covers \Hyde\Framework\Concerns\HydePage
* @covers \Hyde\Framework\Concerns\BaseMarkdownPage
* @covers \Hyde\Framework\Actions\Constructors\FindsNavigationDataForPage
* @covers \Hyde\Framework\Concerns\ConstructsPageSchemas
* @covers \Hyde\Framework\Concerns\Internal\ConstructsPageSchemas
*/
class HydePageTest extends TestCase
{
Expand Down
2 changes: 1 addition & 1 deletion packages/framework/tests/Feature/MarkdownPostTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

/**
* @covers \Hyde\Framework\Models\Pages\MarkdownPost
* @covers \Hyde\Framework\Concerns\ConstructsPageSchemas
* @covers \Hyde\Framework\Concerns\Internal\ConstructsPageSchemas
*/
class MarkdownPostTest extends TestCase
{
Expand Down
2 changes: 1 addition & 1 deletion packages/framework/tests/Feature/PageModelConstructorsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
* Test the constructor actions and schema constructors for page models.
*
* @covers \Hyde\Framework\Actions\Constructors\FindsTitleForPage
* @covers \Hyde\Framework\Concerns\ConstructsPageSchemas
* @covers \Hyde\Framework\Concerns\Internal\ConstructsPageSchemas
*/
class PageModelConstructorsTest extends TestCase
{
Expand Down
2 changes: 1 addition & 1 deletion packages/framework/tests/Feature/Services/DocumentationSidebarTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

/**
* @covers \Hyde\Framework\Models\Navigation\DocumentationSidebar
* @covers \Hyde\Framework\Concerns\ConstructsPageSchemas
* @covers \Hyde\Framework\Concerns\Internal\ConstructsPageSchemas
*/
class DocumentationSidebarTest extends TestCase
{
Expand Down
2 changes: 1 addition & 1 deletion packages/framework/tests/Unit/DocumentationPageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

/**
* @covers \Hyde\Framework\Models\Pages\DocumentationPage
* @covers \Hyde\Framework\Concerns\ConstructsPageSchemas
* @covers \Hyde\Framework\Concerns\Internal\ConstructsPageSchemas
*/
class DocumentationPageTest extends TestCase
{
Expand Down