Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change version method to return the new version constant instead of using Composer #575

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

caendesilva
Copy link
Member

If you want to get the "real" installed version, you can still use the following (which was the old behaviour)

Composer\InstalledVersions::getPrettyVersion('hyde/framework')

@caendesilva caendesilva marked this pull request as ready for review October 24, 2022 19:08
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #575 (05ac1d2) into master (10b274b) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #575   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity       973       972    -1     
===========================================
  Files            113       113           
  Lines           2407      2407           
===========================================
  Hits            2407      2407           
Impacted Files Coverage Δ
packages/framework/src/HydeKernel.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva merged commit 9e7cadf into master Oct 24, 2022
@caendesilva caendesilva deleted the use-version-constant branch October 24, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant