Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor navigation data handling #577

Merged
merged 36 commits into from
Oct 25, 2022
Merged

Refactor navigation data handling #577

merged 36 commits into from
Oct 25, 2022

Conversation

caendesilva
Copy link
Member

Aims to reduce complexity for the navigation data handling

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #577 (6f25a58) into master (7929d2c) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 6f25a58 differs from pull request most recent head d43dfeb. Consider uploading reports for the commit d43dfeb to get more accurate results

@@             Coverage Diff             @@
##              master      #577   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       973       974    +1     
===========================================
  Files            113       113           
  Lines           2414      2415    +1     
===========================================
+ Hits            2414      2415    +1     
Impacted Files Coverage Δ
packages/framework/src/Concerns/HydePage.php 100.00% <ø> (ø)
...ctions/Constructors/FindsNavigationDataForPage.php 100.00% <100.00%> (ø)
...rk/src/Concerns/Internal/ConstructsPageSchemas.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review October 25, 2022 15:18
@caendesilva caendesilva merged commit 3112d25 into master Oct 25, 2022
@caendesilva caendesilva deleted the clean-up-navigation branch October 25, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants