Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Add strict types declaration to all Framework PHP source files #586

Merged
merged 20 commits into from
Oct 26, 2022

Conversation

caendesilva
Copy link
Member

No description provided.

@caendesilva
Copy link
Member Author

This requires a lot of refactors, which is good as it fixes undiscovered type bugs.

Wondering which looks prettiest

return $this->__toString();

return (string) $this;

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #586 (c05087b) into master (fe113db) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #586   +/-   ##
=========================================
  Coverage     99.95%   99.95%           
- Complexity      974      975    +1     
=========================================
  Files           114      114           
  Lines          2409     2411    +2     
=========================================
+ Hits           2408     2410    +2     
  Misses            1        1           
Impacted Files Coverage Δ
...ckages/framework/src/Actions/BladeMatterParser.php 100.00% <ø> (ø)
.../Constructors/FindsContentLengthForImageObject.php 100.00% <ø> (ø)
...ctions/Constructors/FindsNavigationDataForPage.php 97.95% <ø> (ø)
...ork/src/Actions/Constructors/FindsTitleForPage.php 100.00% <ø> (ø)
...amework/src/Actions/ConvertsArrayToFrontMatter.php 100.00% <ø> (ø)
...amework/src/Actions/CreatesNewMarkdownPostFile.php 100.00% <ø> (ø)
...framework/src/Actions/CreatesNewPageSourceFile.php 100.00% <ø> (ø)
...rk/src/Actions/GeneratesSidebarTableOfContents.php 100.00% <ø> (ø)
...ckages/framework/src/Actions/MarkdownConverter.php 100.00% <ø> (ø)
...kages/framework/src/Actions/MarkdownFileParser.php 100.00% <ø> (ø)
... and 104 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva added this to the v1 milestone Oct 26, 2022
@caendesilva caendesilva marked this pull request as ready for review October 26, 2022 13:18
@caendesilva caendesilva merged commit 37f108b into master Oct 26, 2022
@caendesilva caendesilva deleted the enable-strict-types branch October 26, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants