Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize almost all Framework namespaces #594

Merged
merged 18 commits into from
Oct 26, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Oct 26, 2022

An incredibly breaking pull request, as it modifies literally every single Framework file, and changes the namespaces for half of them.

I do feel like this is the time to do stuff like this, since next release is v1.0, and it's now or never. Hopefully these breaking changes will lead to better stability and maintainability in the future.

This would likely solve the sentiment of, and fix #592, and likewise fix #579

@caendesilva caendesilva changed the title Reorganize all namespaces Experiment in reorganizing all namespaces Oct 26, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #594 (79a6964) into experimental (50d1bdf) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 79a6964 differs from pull request most recent head ee30113. Consider uploading reports for the commit ee30113 to get more accurate results

@@               Coverage Diff               @@
##             experimental     #594   +/-   ##
===============================================
  Coverage           99.95%   99.95%           
  Complexity            975      975           
===============================================
  Files                 114      114           
  Lines                2413     2413           
===============================================
  Hits                 2412     2412           
  Misses                  1        1           
Impacted Files Coverage Δ
...s/framework/src/DataCollections/DataCollection.php 100.00% <ø> (ø)
.../DataCollections/DataCollectionServiceProvider.php 100.00% <ø> (ø)
...src/DataCollections/Facades/MarkdownCollection.php 100.00% <ø> (ø)
packages/framework/src/Foundation/Application.php 100.00% <ø> (ø)
...c/Foundation/Concerns/BaseFoundationCollection.php 100.00% <ø> (ø)
...ork/src/Foundation/Concerns/ForwardsFilesystem.php 100.00% <ø> (ø)
...ork/src/Foundation/Concerns/ForwardsHyperlinks.php 100.00% <ø> (ø)
...undation/Concerns/HandlesFoundationCollections.php 100.00% <ø> (ø)
...rc/Foundation/Concerns/ImplementsStringHelpers.php 100.00% <ø> (ø)
...work/src/Foundation/Concerns/ManagesHydeKernel.php 100.00% <ø> (ø)
... and 104 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva force-pushed the reorganize-all-namespaces branch from 6a7c70e to c24507b Compare October 26, 2022 17:25
@caendesilva caendesilva force-pushed the reorganize-all-namespaces branch from c24507b to aff08a9 Compare October 26, 2022 17:28
@caendesilva caendesilva changed the title Experiment in reorganizing all namespaces Reorganize almost all Framework namespaces Oct 26, 2022
@caendesilva caendesilva changed the base branch from master to experimental October 26, 2022 17:45
@caendesilva caendesilva marked this pull request as ready for review October 26, 2022 17:46
@caendesilva caendesilva merged commit ee0b417 into experimental Oct 26, 2022
@caendesilva caendesilva deleted the reorganize-all-namespaces branch October 26, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants