Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactors #650

Merged
merged 23 commits into from
Nov 7, 2022
Merged

Code refactors #650

merged 23 commits into from
Nov 7, 2022

Conversation

caendesilva
Copy link
Member

These refactors should not have any affect on behaviour.

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #650 (2bb888d) into master (1372856) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #650   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1019      1020    +1     
===========================================
  Files            126       126           
  Lines           2542      2544    +2     
===========================================
+ Hits            2542      2544    +2     
Impacted Files Coverage Δ
...mework/src/Foundation/Concerns/ManagesViewData.php 100.00% <ø> (ø)
...rk/src/Framework/Features/Metadata/MetadataBag.php 100.00% <ø> (ø)
.../Framework/Features/Metadata/GlobalMetadataBag.php 100.00% <100.00%> (ø)
...mework/Features/XmlGenerators/BaseXmlGenerator.php 100.00% <100.00%> (ø)
...mework/Features/XmlGenerators/RssFeedGenerator.php 100.00% <100.00%> (ø)
...mework/Features/XmlGenerators/SitemapGenerator.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review November 7, 2022 19:49
@caendesilva caendesilva merged commit 61ce3ca into master Nov 7, 2022
@caendesilva caendesilva deleted the code-refactors branch November 7, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants