Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code API between the File model and collections #657

Merged
merged 17 commits into from
Nov 9, 2022

Conversation

caendesilva
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #657 (e5ab5fa) into master (3f6a605) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #657   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1030      1035    +5     
===========================================
  Files            130       130           
  Lines           2562      2567    +5     
===========================================
+ Hits            2562      2567    +5     
Impacted Files Coverage Δ
...c/Foundation/Concerns/BaseFoundationCollection.php 100.00% <100.00%> (ø)
...ckages/framework/src/Foundation/FileCollection.php 100.00% <100.00%> (ø)
packages/framework/src/Support/Models/File.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@what-the-diff
Copy link

what-the-diff bot commented Nov 9, 2022

  • Added support for Arrayable in BaseFoundationCollection
  • Changed the way source files are filtered to use a new method on File model instead of checking if belongsTo is null or not
  • Added methods to check if file belongs to page, and whether it's a media file or not (source)

@caendesilva caendesilva changed the title Code refactors Improve code API between the File model and collections Nov 9, 2022
@caendesilva caendesilva marked this pull request as ready for review November 9, 2022 20:26
@caendesilva caendesilva merged commit 604c70d into master Nov 9, 2022
@caendesilva caendesilva deleted the code-refactors branch November 9, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants