Refactor publication service and add tests for it#694

Merged

caendesilva merged 81 commits intopublications-featurefrom refactor-PublicationService

Nov 25, 2022

Commits on Nov 25, 2022

Inline and remove method PublicationService::formatNameForStorage
caendesilva
committed
Test getPublicationTypes helper
caendesilva
committed
Use Hyde::path helper instead of base_path for better compatibility
caendesilva
committed
Cleanup code
caendesilva
committed
Extract method
caendesilva
committed
Change helper to void
caendesilva
committed
Add more tests
caendesilva
committed
Cleanup code
caendesilva
committed
Add assertion
caendesilva
committed
Split out assertion to new test method
caendesilva
committed
Split comma-separated values into multiple lines
caendesilva
committed
Use strong types for sorting callback
caendesilva
committed
Convert closure to arrow function
caendesilva
committed
Union type int
caendesilva
committed
Use the sortDirection schema option
caendesilva
committed
Test sorting
caendesilva
committed
Extract method
caendesilva
committed
Remove collection sorting to reduce complexity
caendesilva
committed
Rename method getPublicationData to parsePublicationFile
caendesilva
committed
Replace qualifier with an import
caendesilva
committed
Add parameter example
caendesilva
committed
Read file using absolute path
caendesilva
committed
Remove unused use statement
caendesilva
committed
Apply fixes from StyleCI
StyleCIBot
committed
Remove redundant __slug magic front matter property
caendesilva
committed
Merge branch 'refactor-PublicationService' of github.com:hydephp/develop into refactor-PublicationService
caendesilva
committed
Pass along relative path
caendesilva
committed
Test publicationTypeExists method
caendesilva
committed
Simplify publicationTypeExists by inlining conditional
caendesilva
committed
Remove redundant PHPDoc
caendesilva
committed
Remove __createdDatetime magic front matter property
caendesilva
committed
Inline local variables
caendesilva
committed
Unwrap unnecessary basename function call
caendesilva
committed
Add name identifiers to arguments
caendesilva
committed
Revert "Remove redundant PHPDoc"
caendesilva
committed
Extract helper
caendesilva
committed
Remove throws tags not thrown within method body
caendesilva
committed
Remove generic throws tags without documentation
caendesilva
committed
Refactor foreach loop with collection mapper
caendesilva
committed
Type return value
caendesilva
committed
Remove unused glob flag
caendesilva
committed
Add todo
caendesilva
committed
Add fixme
caendesilva
committed
Extract helper
caendesilva
committed
Convert string interpolation to concatenation and inline variable
caendesilva
committed
Respect custom content roots
caendesilva
committed
Add todo
caendesilva
committed
Apply fixes from StyleCI
StyleCIBot
committed
Update PHPDoc comment
caendesilva
committed
Rename internal parameter
caendesilva
committed
Refactor parsePublicationFile method to use identifier to match pages
caendesilva
committed
Normalize identifier to allow included extension
caendesilva
committed
Use basename for identifier that is concatenated in its constructor
caendesilva
committed
Test parsePublicationFile method
caendesilva
committed
Add parsing error tests
caendesilva
committed
Add throws tag
caendesilva
committed
Apply fixes from StyleCI
StyleCIBot
committed
Finish PHPDoc with period for style
caendesilva
committed
Use absolute path when interacting with the filesystem
caendesilva
committed
Remove premature file path qualifier
caendesilva
committed
Remove premature file path qualifier
caendesilva
committed
Use relative paths for method arguments
caendesilva
committed
Import functions
caendesilva
committed
Convert paths to relative within the glob helper
caendesilva
committed
Revert "Convert paths to relative within the glob helper"
caendesilva
committed
Apply fixes from StyleCI
StyleCIBot
committed
Remove todo as it's handled by global media paths
caendesilva
committed
Add _media prefix within helper so it normalizes directory separators
caendesilva
committed
Test getMediaForPubType helper
caendesilva
committed
Paths must be stored relatively internally
caendesilva
committed
Refactor foreach loops to use collection mappers
caendesilva
committed
Refactor to pass data to path helper
caendesilva
committed
Convert string interpolation to concatenation and inline local variable
caendesilva
committed
Replace local variables with helper methods
caendesilva
committed
Apply fixes from StyleCI
StyleCIBot
committed
Update PHPDoc to match simplified method
caendesilva
committed
Shorten helper method name
caendesilva
committed
Shift where ->getDirectory() is called
caendesilva
committed
Convert concatenation to a scalar value
caendesilva
committed
Introduce parameter
caendesilva
committed
Replace self with static
caendesilva
committed